Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve value from DocValues in a flat_object filed #16802

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Retrieve value from DocValues in a flat_object filed #16802

wants to merge 1 commit into from
+150 −16

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Dec 8, 2024 •
edited
Loading

Description

Added ability to retrieve value from DocValues in a flat_object filed

Related Issues

Resolves #16742

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing Storage:Performance labels Dec 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024

❌ Gradle check result for 31a060d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the float_object_doc_value branch from 31a060d to 6054295 Compare December 8, 2024 20:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024

❌ Gradle check result for 6054295: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the float_object_doc_value branch from 6054295 to 5f51b30 Compare December 9, 2024 03:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

❌ Gradle check result for 5f51b30: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@msfroh
Copy link
Collaborator

msfroh commented Dec 11, 2024 •
edited
Loading

@kkewwei -- I plan to review this PR this week. (Lots of meetings this week, but should have time Thursday or Friday.) Please @ me or bug me on OpenSearch Slack if I don't!

@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 11, 2024

@kkewwei -- I plan to review this PR this week. (Lots of meetings this week, but should have time Thursday or Friday.) Please @ me or bug me on OpenSearch Slack if I don't!

Thank you very much, some of the unit tests are not ready, I will fix soon and at you when all is ready.

@kkewwei kkewwei force-pushed the float_object_doc_value branch from 5f51b30 to 218a8bb Compare December 11, 2024 12:16
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 54cd837: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the float_object_doc_value branch 3 times, most recently from 4523b74 to a41d71e Compare December 11, 2024 14:04
@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 11, 2024

❌ Gradle check result for 54cd837: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

SearchTimeoutIT.testSimpleTimeout #16056

@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 11, 2024

@kkewwei -- I plan to review this PR this week. (Lots of meetings this week, but should have time Thursday or Friday.) Please @ me or bug me on OpenSearch Slack if I don't!

Thank you very much, some of the unit tests are not ready, I will fix soon and at you when all is ready.

TBR.

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for a41d71e: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.26%. Comparing base (7050ecf) to head (cf49717).

Files with missing lines Patch % Lines
...opensearch/index/mapper/FlatObjectFieldMapper.java 54.54% 7 Missing and 3 partials ⚠️
...a/org/opensearch/index/mapper/DocValueFetcher.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #16802      +/-   ##
============================================
+ Coverage     72.19%   72.26%   +0.06%     
- Complexity    65208    65253      +45     
============================================
  Files          5297     5297              
  Lines        303324   303347      +23     
  Branches      43913    43918       +5     
============================================
+ Hits         218999   219200     +201     
+ Misses        66367    66170     -197     
- Partials      17958    17977      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Dec 10, 2024
Closed
@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 12, 2024

❕ Gradle check result for a41d71e: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

SearchRestCancellationIT.testAutomaticCancellationDuringFetchPhase #14311

@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 16, 2024

OpenSearch

@msfroh please have a look when you are free.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 5714d79: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Dec 16, 2024
Open
@kkewwei kkewwei force-pushed the float_object_doc_value branch from 5714d79 to d4cd439 Compare December 18, 2024 04:01
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d4cd439: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 20, 2024
Open
@kkewwei kkewwei force-pushed the float_object_doc_value branch from d4cd439 to 237fce1 Compare December 19, 2024 11:41
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 237fce1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Dec 19, 2024
Open
@kkewwei kkewwei force-pushed the float_object_doc_value branch from 237fce1 to cf49717 Compare December 20, 2024 09:05
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for cf49717: SUCCESS

@msfroh msfroh added the backport 2.x Backport to 2.x branch label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfroh msfroh msfroh approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing Storage:Performance
Projects
Storage Project Board
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Retrieve value from DocValues in a flat_object filed
2 participants
@kkewwei @msfroh